-
-
Notifications
You must be signed in to change notification settings - Fork 186
feat: add new cmd in the Playground sv create --from-playground
#1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <code>
looks really out of place here, and the font-size and baseline are all wrong. I think it would be better to have something like this
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
…te.dev into feat/playground-add-sv-cmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! love this feature
…eltejs#1537) * feat: add new cmd in the Playground `sv create --from-playground` * css > alert * title & aria-label Co-authored-by: Rich Harris <[email protected]> * button text Co-authored-by: Rich Harris <[email protected]> * remove implicit size Co-authored-by: Rich Harris <[email protected]> * position & mask Co-authored-by: Rich Harris <[email protected]> --------- Co-authored-by: Rich Harris <[email protected]>
Since
[email protected]
, we can create a project from the playground (check the doc)To help the discoverability of this feature, we can add the command in the playground like this:
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.